Misc fixes, part 2 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow custom options sourced from optional /etc/default/smcrouted - don't enable smcrouted by default when enabled in Buildroot .config because normal use-cases require an /etc/smcroute.conf Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
In normal use-cases querierd needs a bridge with multicast-snooping enabled to run. No point in attempting to start querierd by default. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This script has some seriously sharp edges. Today two devs cut their fingers on it trying to get new functionality in place. One when, in a attempt at, adding an innocent status daemon, and another setting up a client repository with a custom, enabled-by-default, daemon. In both instances this script happily cleaned out the deamons from enabled/. A better alternative, as described in issue #74, is to be stricter on what is enabled by default, and for things we feel provide value in the Classic build, maintain a separate list of symlinks in its meta board definitiion instead. Also, clean out previous attempt at factory-config. Now that we have the auto-factory support in place we don't need this. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
The packages have a misspelled license file. Sneaky Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
For some reason, the `make license-info` target complained klinfix needed a hash file, but not the other local repos. Issue #67 tracks adding license-info to releases, which will need some looking into, for now this fixes the most glaring packaging oversights. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
rical
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivator for this PR was issue #74, which we both ran into hard today. But since I'm in cleaning mode, I've not only dropped the
clean-etcscript, but also went through the Finit .conf files that are enabled by default, and adjusted accordingly. A few more services now run, e.g. SNMP, which we want anyway but don't have modeled in YANG yet.As a bonus, I noticed and fixed some packaging issues with missing LICENSE statements (required by our customers).
A recurring extra fun-fun thing is the long running effort at addressing Bob's reluctance to upload latest built artifacts to our Latest Build release. This one will be the death of me.